Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrong marketplaceInfo value being stored in the database #35009

Merged
merged 10 commits into from
Jan 30, 2025
Merged

fix: Wrong marketplaceInfo value being stored in the database #35009

merged 10 commits into from
Jan 30, 2025

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Jan 22, 2025 •
edited by d-gubert
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CONN-481

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 22, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 736221e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps-engine Patch
@rocket.chat/models Patch
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/presence Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/freeswitch Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Gustrb Gustrb added this to the 7.4.0 milestone Jan 22, 2025
@Gustrb Gustrb requested a review from d-gubert January 22, 2025 19:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35009/

Built to branch gh-pages at 2025-01-29 23:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.17%. Comparing base (5ba70b1) to head (736221e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35009      +/-   ##
===========================================
- Coverage    59.17%   59.17%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        68066    68067       +1     
  Branches     15134    15135       +1     
===========================================
  Hits         40281    40281              
  Misses       24955    24955              
- Partials      2830     2831       +1
Flag Coverage Δ
unit 75.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review January 22, 2025 20:48
@Gustrb Gustrb requested a review from a team as a code owner January 22, 2025 20:48
@d-gubert d-gubert force-pushed the fix/wrong-marketplaceinfo branch from 0d3180f to 6b083c2 Compare January 22, 2025 23:13
@d-gubert d-gubert marked this pull request as draft January 24, 2025 13:11
@Gustrb Gustrb marked this pull request as ready for review January 28, 2025 13:16
@Gustrb Gustrb requested a review from a team as a code owner January 28, 2025 13:16
@d-gubert d-gubert modified the milestones: 7.4.0, 7.3.0 Jan 29, 2025
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jan 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 29, 2025
@kodiakhq kodiakhq bot merged commit 0fef2bb into develop Jan 30, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/wrong-marketplaceinfo branch January 30, 2025 00:24
ggazzo pushed a commit that referenced this pull request Jan 31, 2025
@Gustrb @d-gubert @ggazzo
fix: Wrong marketplaceInfo value being stored in the database (#35009)
c0fa1c8 
Co-authored-by: Douglas Gubert <[email protected]>
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapiarafael tapiarafael tapiarafael approved these changes

@d-gubert d-gubert Awaiting requested review from d-gubert

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Gustrb @tapiarafael @d-gubert